Feature/double named dominance edges in index update by MartinKl · Pull Request #347 · korpling/graphANNIS

MartinKl · 2026-10-09T09:17:38Z

This implements doubling named dominance edges into the default dominance component after performing a graph update. Doubling of edges takes place in AnnotationComponentType::apply_update_graph_index.

This might require benchmarking, I leave this to you @thomaskrause

…ce edges in the unnamed default dominance component. To keep this load off the corpus building side, it is integrated into apply_update_graph_index of AnnotationComponent

… in any other unnamed component

github-actions · 2026-10-12T16:09:11Z

Commit f467758

-------------
Diff Coverage
Diff: origin/main...HEAD, staged and unstaged changes
-------------
graphannis/src/annis/db/aql/model.rs (100%)
graphannis/src/annis/db/aql/operators/arity.rs (100%)
graphannis/src/annis/db/aql/operators/edge_op.rs (100%)
-------------
Total:   53 lines
Missing: 0 lines
Coverage: 100%
-------------

…ble-named-dominance-edges-in-index-update

thomaskrause

I did change some things to make it more consistent with previous relANNIS behavior, e.g. the edges are only added if there is no other unnamed dominance component in another layer.

I also added a benchmark to check that that performance is not negativly impacted and overall this looks good to me. I will have to run the search tests/benchmarks with the newly imported corpora to check that the results are actually the same even after re-importing the corpora using the new code.

thomaskrause · 2026-10-13T08:07:35Z

Benchmark result from my computer.

group                                   fix-dom-edges                          main
-----                                   -------------                          ----
GUM/DirectPointingWithAnno              1.27  1233.6±26.33µs        ? ?/sec    1.00    970.0±4.89µs        ? ?/sec
GUM/InvalidNonExisting                  1.02      9.0±0.06µs        ? ?/sec    1.00      8.8±0.02µs        ? ?/sec
GUM/NegationDep                         1.07  1049.3±16.59µs        ? ?/sec    1.00   984.4±35.15µs        ? ?/sec
GUM/NegationDepAnno                     1.03  1011.6±37.13µs        ? ?/sec    1.00    984.4±6.90µs        ? ?/sec
GUM/NegationDominance                   1.04    112.0±4.60ms        ? ?/sec    1.00    108.2±3.82ms        ? ?/sec
GUM/NegationDominanceMultiple           1.02   794.0±15.69µs        ? ?/sec    1.00    778.2±5.97µs        ? ?/sec
GUM/NegationIdentCoverage               1.08     81.6±1.38ms        ? ?/sec    1.00     75.3±1.27ms        ? ?/sec
GUM/NegationInclusion                   1.02      3.9±0.28ms        ? ?/sec    1.00      3.9±0.20ms        ? ?/sec
GUM/NegationLeftAligned                 1.07     80.8±0.73ms        ? ?/sec    1.00     75.3±1.27ms        ? ?/sec
GUM/NegationNear                        1.00     18.1±0.66ms        ? ?/sec    1.01     18.2±0.73ms        ? ?/sec
GUM/NegationNodeIdentity                1.00  1363.5±31.58µs        ? ?/sec    1.01   1382.8±8.80µs        ? ?/sec
GUM/NegationOverlap                     1.01      3.7±0.16ms        ? ?/sec    1.00      3.7±0.17ms        ? ?/sec
GUM/NegationPartOf                      1.00    375.5±7.75ms        ? ?/sec    1.03   387.4±16.55ms        ? ?/sec
GUM/NegationPrecedence                  1.00     17.9±0.59ms        ? ?/sec    1.02     18.2±1.07ms        ? ?/sec
GUM/NegationRightAligned                1.05     79.4±1.52ms        ? ?/sec    1.00     75.7±2.33ms        ? ?/sec
GUM/NonExistingDepAnno                  1.00     37.8±0.21µs        ? ?/sec    1.03     39.0±0.78µs        ? ?/sec
GUM/NonExistingDominance                1.00     75.8±1.06ms        ? ?/sec    1.00     75.6±1.02ms        ? ?/sec
GUM/NonExistingIdentCoverage            1.00      6.6±0.37ms        ? ?/sec    1.06      7.0±1.07ms        ? ?/sec
GUM/NonExistingIdentCoverageInv         1.01      7.0±0.40ms        ? ?/sec    1.00      6.9±0.49ms        ? ?/sec
GUM/NonExistingInclusion                1.04    473.7±4.33µs        ? ?/sec    1.00    455.2±7.45µs        ? ?/sec
GUM/NonExistingLeftAligned              1.00    344.1±1.61µs        ? ?/sec    1.02    352.2±6.30µs        ? ?/sec
GUM/NonExistingLeftInv                  1.00    356.6±4.11µs        ? ?/sec    1.01    360.0±2.01µs        ? ?/sec
GUM/NonExistingNear                     1.00    127.6±3.87µs        ? ?/sec    1.03    131.6±0.92µs        ? ?/sec
GUM/NonExistingOverlap                  1.02   812.8±22.09µs        ? ?/sec    1.00   800.3±12.25µs        ? ?/sec
GUM/NonExistingOverlapInv               1.02   827.6±23.44µs        ? ?/sec    1.00   810.0±25.21µs        ? ?/sec
GUM/NonExistingPartOf                   1.00      2.9±0.09ms        ? ?/sec    1.09      3.1±0.17ms        ? ?/sec
GUM/NonExistingPrecedence               1.00    125.0±0.84µs        ? ?/sec    1.02    127.9±0.47µs        ? ?/sec
GUM/NonExistingRight                    1.01    376.1±1.97µs        ? ?/sec    1.00    373.1±4.60µs        ? ?/sec
GUM/NonExistingRightInv                 1.01    373.9±7.50µs        ? ?/sec    1.00    370.8±2.66µs        ? ?/sec
GUM/OptionalQueryAlternative            1.04     21.1±0.83ms        ? ?/sec    1.00     20.2±0.73ms        ? ?/sec
GUM/OptionalQueryNodeAtEnd              1.03     12.9±0.62ms        ? ?/sec    1.00     12.5±0.56ms        ? ?/sec
GUM/OptionalQueryNodeInBetween          1.05     13.3±0.90ms        ? ?/sec    1.00     12.6±0.41ms        ? ?/sec
GUM/Profile                             1.25     21.8±2.15ms        ? ?/sec    1.00     17.4±0.56ms        ? ?/sec
GUM/VV_dep                              1.02     19.5±1.29ms        ? ?/sec    1.00     19.1±1.28ms        ? ?/sec
GUM/city                                1.03    608.2±3.83µs        ? ?/sec    1.00    588.9±4.56µs        ? ?/sec
GUM/coffee                              1.01    398.5±3.18µs        ? ?/sec    1.00    394.0±7.70µs        ? ?/sec
GUM/corefAnno                           1.14  1847.7±28.66µs        ? ?/sec    1.00  1626.3±32.54µs        ? ?/sec
GUM/dep_xcomp                           1.00     39.1±0.59µs        ? ?/sec    1.03     40.2±0.38µs        ? ?/sec
GUM/edge_anno_regex                     1.00    304.3±1.26ms        ? ?/sec    1.03    314.8±3.93ms        ? ?/sec
GUM/entity                              1.00      4.0±0.10ms        ? ?/sec    1.01      4.1±0.08ms        ? ?/sec
GUM/kind_dom_kind                       1.17      6.9±0.20ms        ? ?/sec    1.00      5.9±0.03ms        ? ?/sec
GUM/meta_interview                      1.02      4.7±0.21ms        ? ?/sec    1.00      4.6±0.15ms        ? ?/sec
GUM/nonexisting_dep                     1.02    128.3±1.05µs        ? ?/sec    1.00    126.2±1.14µs        ? ?/sec
GUM/noun_with_metadata                  1.00      2.3±0.02ms        ? ?/sec    1.02      2.4±0.02ms        ? ?/sec
GUM/tok_dep_tok                         1.13     21.4±0.86ms        ? ?/sec    1.00     19.0±0.66ms        ? ?/sec
apply_update_complex_graph              1.03      3.4±0.20ms        ? ?/sec    1.00      3.4±0.22ms        ? ?/sec
apply_update_inmemory                   1.03       2.3±0.05s        ? ?/sec    1.00       2.3±0.02s        ? ?/sec
apply_update_ondisk                     1.01       5.7±0.09s        ? ?/sec    1.00       5.6±0.08s        ? ?/sec
count_extra_coref_anno                  1.00      2.9±0.18ms        ? ?/sec    1.07      3.1±0.24ms        ? ?/sec
count_extra_node                        1.00     26.1±0.21ms        ? ?/sec    1.01     26.4±0.31ms        ? ?/sec
deserialize_gum                         1.00    111.3±4.95ms        ? ?/sec    1.01    112.2±4.83ms        ? ?/sec
find_all_nouns_gum                      1.00     35.0±0.96ms        ? ?/sec    1.04     36.4±1.94ms        ? ?/sec
find_extra_all_nouns_gum                1.00     35.4±0.89ms        ? ?/sec    1.00     35.3±0.93ms        ? ?/sec
find_extra_first_ten_nouns_gum          1.06      9.2±0.60ms        ? ?/sec    1.00      8.6±0.37ms        ? ?/sec
find_extra_first_ten_token_gum          1.06     77.5±2.17µs        ? ?/sec    1.00     73.2±0.74µs        ? ?/sec
find_first_ten_nouns_gum                1.00      8.6±0.44ms        ? ?/sec    1.05      9.0±0.57ms        ? ?/sec
find_first_ten_token_gum                1.00     74.8±0.82µs        ? ?/sec    1.04     77.9±1.25µs        ? ?/sec
pcc2.1/AnyNodeIncludeSeed               1.02    295.8±5.84ms        ? ?/sec    1.00    290.7±2.73ms        ? ?/sec
pcc2.1/Benchmark1                       1.00     10.4±0.41ms        ? ?/sec    1.03     10.7±0.65ms        ? ?/sec
pcc2.1/Benchmark2                       1.00     84.0±1.61ms        ? ?/sec    1.06     89.1±2.81ms        ? ?/sec
pcc2.1/BrandenBurgSentence              1.04     11.4±0.25ms        ? ?/sec    1.00     11.0±0.33ms        ? ?/sec
pcc2.1/CatSearch                        1.05   675.3±11.27µs        ? ?/sec    1.00    642.3±9.73µs        ? ?/sec
pcc2.1/ConjunctionNearNounDirect        1.00  1323.1±26.11µs        ? ?/sec    1.02  1352.7±28.44µs        ? ?/sec
pcc2.1/ConjunctionNearNounDistance      1.00   955.6±21.42µs        ? ?/sec    1.03   987.1±14.56µs        ? ?/sec
pcc2.1/ConjunctionNearNounIndirect      1.00     44.5±0.91ms        ? ?/sec    1.05     46.8±1.32ms        ? ?/sec
pcc2.1/ConjunctionNearNounRange         1.00  1469.0±31.55µs        ? ?/sec    1.04  1530.7±56.54µs        ? ?/sec
pcc2.1/DepthFirst                       1.00     37.3±0.72µs        ? ?/sec    1.02     38.1±0.29µs        ? ?/sec
pcc2.1/DirectPointing                   1.00    205.8±4.24µs        ? ?/sec    1.02    209.2±1.47µs        ? ?/sec
pcc2.1/Inclusion                        1.00   830.2±11.38µs        ? ?/sec    1.01   836.4±17.70µs        ? ?/sec
pcc2.1/InclusionQuery                   1.00     10.6±0.43ms        ? ?/sec    1.01     10.7±0.75ms        ? ?/sec
pcc2.1/IndirectPointing                 1.04    281.6±6.88µs        ? ?/sec    1.00    271.4±1.44µs        ? ?/sec
pcc2.1/IsConnectedRange                 1.02     45.5±1.30µs        ? ?/sec    1.00     44.7±0.49µs        ? ?/sec
pcc2.1/KarolaAlignLemma                 1.00   292.1±10.21µs        ? ?/sec    1.00    292.9±8.63µs        ? ?/sec
pcc2.1/KarolaAlignTok                   1.01    326.1±8.50µs        ? ?/sec    1.00    321.7±3.01µs        ? ?/sec
pcc2.1/KarolaOr                         1.00     60.0±1.89µs        ? ?/sec    1.02     61.2±1.34µs        ? ?/sec
pcc2.1/LemmaTokEqual                    1.03    694.6±4.55µs        ? ?/sec    1.00    673.5±6.04µs        ? ?/sec
pcc2.1/LemmaTokNotEqual                 1.00    692.9±5.98µs        ? ?/sec    1.00   693.7±32.53µs        ? ?/sec
pcc2.1/MMaxAnnos_ambiguity              1.03    262.0±0.73µs        ? ?/sec    1.00    254.7±2.62µs        ? ?/sec
pcc2.1/MMaxAnnos_complex_np             1.06     84.8±0.99µs        ? ?/sec    1.00     79.8±1.22µs        ? ?/sec
pcc2.1/MultiDominance                   1.07     67.8±2.32ms        ? ?/sec    1.00     63.4±3.39ms        ? ?/sec
pcc2.1/NNNearARTDIndirect               1.00    139.6±0.88ms        ? ?/sec    1.08    151.0±3.54ms        ? ?/sec
pcc2.1/NNNearARTDirect                  1.00      3.8±0.17ms        ? ?/sec    1.01      3.8±0.15ms        ? ?/sec
pcc2.1/NPThreeOut                       2.81    411.1±6.65ms        ? ?/sec    1.00    146.4±4.82ms        ? ?/sec
pcc2.1/NewInDirect                      1.00   385.1±12.36µs        ? ?/sec    1.03    394.9±5.39µs        ? ?/sec
pcc2.1/NodeCount                        1.05      3.5±0.01ms        ? ?/sec    1.00      3.3±0.01ms        ? ?/sec
pcc2.1/NodeIdentCovNode                 1.00     83.8±1.38ms        ? ?/sec    1.02     85.3±1.72ms        ? ?/sec
pcc2.1/NonExistingDominanceLeft         1.83   792.1±29.09µs        ? ?/sec    1.00    432.6±3.48µs        ? ?/sec
pcc2.1/NotDocument                      1.01     16.6±0.81ms        ? ?/sec    1.00     16.5±0.73ms        ? ?/sec
pcc2.1/NotNoun                          1.00      5.0±0.33ms        ? ?/sec    1.01      5.0±0.41ms        ? ?/sec
pcc2.1/NotProperNound                   1.00      5.0±0.33ms        ? ?/sec    1.01      5.0±0.16ms        ? ?/sec
pcc2.1/NotWennExact                     1.00     44.5±0.57µs        ? ?/sec    1.00     44.7±0.86µs        ? ?/sec
pcc2.1/NotWennRegex                     1.00     93.2±1.01µs        ? ?/sec    1.02     95.2±0.86µs        ? ?/sec
pcc2.1/Overlap                          1.04  1667.1±85.75µs        ? ?/sec    1.00  1595.6±45.47µs        ? ?/sec
pcc2.1/PPNotModifier                    1.03      5.3±0.52ms        ? ?/sec    1.00      5.1±0.37ms        ? ?/sec
pcc2.1/PluralNP                         1.04      4.0±0.19ms        ? ?/sec    1.00      3.8±0.19ms        ? ?/sec
pcc2.1/PosEqual                         1.00     31.1±1.22ms        ? ?/sec    1.06     33.0±2.90ms        ? ?/sec
pcc2.1/PosNotEqual                      1.00     14.4±0.86ms        ? ?/sec    1.01     14.6±1.09ms        ? ?/sec
pcc2.1/PosValueSearch                   1.07    315.7±6.79µs        ? ?/sec    1.00    294.0±5.24µs        ? ?/sec
pcc2.1/Precedence                       1.00     45.3±0.72ms        ? ?/sec    1.12     50.6±0.67ms        ? ?/sec
pcc2.1/PrecedenceMixedSpanTok           1.01     39.7±1.21µs        ? ?/sec    1.00     39.1±1.35µs        ? ?/sec
pcc2.1/RangedDominance                  1.01      6.7±0.35ms        ? ?/sec    1.00      6.7±0.31ms        ? ?/sec
pcc2.1/Regex                            1.03     18.5±0.63ms        ? ?/sec    1.00     17.9±0.74ms        ? ?/sec
pcc2.1/SegmentCount                     1.06    132.3±3.49µs        ? ?/sec    1.00    124.7±2.25µs        ? ?/sec
pcc2.1/SegmentNearDirect                1.00    266.6±1.58µs        ? ?/sec    1.02    270.8±3.11µs        ? ?/sec
pcc2.1/SegmentNearIndirect              1.00     10.8±0.46ms        ? ?/sec    1.04     11.2±0.26ms        ? ?/sec
pcc2.1/SegmentNearRange                 1.00   1006.3±8.86µs        ? ?/sec    1.06  1063.1±10.42µs        ? ?/sec
pcc2.1/StructureInclusionSeed           1.13     23.9±1.20ms        ? ?/sec    1.00     21.3±0.91ms        ? ?/sec
pcc2.1/TestQueryOverlap1                1.02     10.6±0.49ms        ? ?/sec    1.00     10.3±0.48ms        ? ?/sec
pcc2.1/TestQueryOverlap2                1.04     10.2±0.57ms        ? ?/sec    1.00      9.9±0.57ms        ? ?/sec
pcc2.1/TokIdentCovNN                    1.00      8.0±0.61ms        ? ?/sec    1.01      8.1±0.68ms        ? ?/sec
pcc2.1/TokIdentCovNode                  1.01      8.1±0.71ms        ? ?/sec    1.00      8.0±0.50ms        ? ?/sec
pcc2.1/TokenIndex                       1.00     35.9±0.63µs        ? ?/sec    1.01     36.1±0.26µs        ? ?/sec
pcc2.1/TokenPrecedence                  1.00      9.9±0.36ms        ? ?/sec    1.04     10.4±0.33ms        ? ?/sec
pcc2.1/TokenPrecedenceThreeNodes        1.00      9.0±0.35ms        ? ?/sec    1.04      9.4±0.31ms        ? ?/sec
subtok.demo/NearSegmentationDirect      1.00     30.7±0.51µs        ? ?/sec    1.01     31.1±0.26µs        ? ?/sec
subtok.demo/NearSegmentationIndirect    1.00     32.4±0.36µs        ? ?/sec    1.02     32.9±0.46µs        ? ?/sec
subtok.demo/NonExistingWithoutValue     1.02     38.1±0.59µs        ? ?/sec    1.00     37.6±0.16µs        ? ?/sec
subtok.demo/ThisTokenized               1.00     31.9±0.41µs        ? ?/sec    1.05     33.5±0.74µs        ? ?/sec

Overall OK, but there are two outlier queries that need to be debugged

pcc2.1/NPThreeOut                     2.81    411.1±6.65ms        ? ?/sec    1.00    146.4±4.82ms        ? ?/sec
pcc2.1/NonExistingDominanceLeft       1.83   792.1±29.09µs        ? ?/sec    1.00    432.6±3.48µs        ? ?/sec

…r (e.g. Dominance)

thomaskrause · 2026-10-14T13:45:49Z

New benchmark results with the fixed in f46758

group                                   fix-dom-edges                          main
-----                                   -------------                          ----
GUM/DirectPointingWithAnno              1.12  1085.6±22.55µs        ? ?/sec    1.00    970.0±4.89µs        ? ?/sec
GUM/InvalidNonExisting                  1.00      8.7±0.02µs        ? ?/sec    1.01      8.8±0.02µs        ? ?/sec
GUM/NegationDep                         1.01   999.1±17.83µs        ? ?/sec    1.00   984.4±35.15µs        ? ?/sec
GUM/NegationDepAnno                     1.01   994.5±23.23µs        ? ?/sec    1.00    984.4±6.90µs        ? ?/sec
GUM/NegationDominance                   1.00    106.1±2.78ms        ? ?/sec    1.02    108.2±3.82ms        ? ?/sec
GUM/NegationDominanceMultiple           1.02   796.6±20.77µs        ? ?/sec    1.00    778.2±5.97µs        ? ?/sec
GUM/NegationIdentCoverage               1.04     78.5±1.95ms        ? ?/sec    1.00     75.3±1.27ms        ? ?/sec
GUM/NegationInclusion                   1.00      3.8±0.20ms        ? ?/sec    1.01      3.9±0.20ms        ? ?/sec
GUM/NegationLeftAligned                 1.04     78.3±1.51ms        ? ?/sec    1.00     75.3±1.27ms        ? ?/sec
GUM/NegationNear                        1.00     17.2±0.45ms        ? ?/sec    1.06     18.2±0.73ms        ? ?/sec
GUM/NegationNodeIdentity                1.01  1396.6±29.42µs        ? ?/sec    1.00   1382.8±8.80µs        ? ?/sec
GUM/NegationOverlap                     1.03      3.8±0.16ms        ? ?/sec    1.00      3.7±0.17ms        ? ?/sec
GUM/NegationPartOf                      1.00    370.4±9.07ms        ? ?/sec    1.05   387.4±16.55ms        ? ?/sec
GUM/NegationPrecedence                  1.00     17.1±0.29ms        ? ?/sec    1.07     18.2±1.07ms        ? ?/sec
GUM/NegationRightAligned                1.02     77.2±1.69ms        ? ?/sec    1.00     75.7±2.33ms        ? ?/sec
GUM/NonExistingDepAnno                  1.01     39.4±0.30µs        ? ?/sec    1.00     39.0±0.78µs        ? ?/sec
GUM/NonExistingDominance                1.00     75.9±0.74ms        ? ?/sec    1.00     75.6±1.02ms        ? ?/sec
GUM/NonExistingIdentCoverage            1.00      6.5±0.58ms        ? ?/sec    1.07      7.0±1.07ms        ? ?/sec
GUM/NonExistingIdentCoverageInv         1.00      6.8±0.62ms        ? ?/sec    1.02      6.9±0.49ms        ? ?/sec
GUM/NonExistingInclusion                1.01    458.9±5.11µs        ? ?/sec    1.00    455.2±7.45µs        ? ?/sec
GUM/NonExistingLeftAligned              1.05    368.9±6.56µs        ? ?/sec    1.00    352.2±6.30µs        ? ?/sec
GUM/NonExistingLeftInv                  1.00    359.5±3.95µs        ? ?/sec    1.00    360.0±2.01µs        ? ?/sec
GUM/NonExistingNear                     1.00    130.6±2.01µs        ? ?/sec    1.01    131.6±0.92µs        ? ?/sec
GUM/NonExistingOverlap                  1.04   833.5±34.46µs        ? ?/sec    1.00   800.3±12.25µs        ? ?/sec
GUM/NonExistingOverlapInv               1.03   835.6±17.70µs        ? ?/sec    1.00   810.0±25.21µs        ? ?/sec
GUM/NonExistingPartOf                   1.00      2.8±0.13ms        ? ?/sec    1.11      3.1±0.17ms        ? ?/sec
GUM/NonExistingPrecedence               1.01    129.1±2.52µs        ? ?/sec    1.00    127.9±0.47µs        ? ?/sec
GUM/NonExistingRight                    1.02    382.4±4.95µs        ? ?/sec    1.00    373.1±4.60µs        ? ?/sec
GUM/NonExistingRightInv                 1.02    379.8±4.13µs        ? ?/sec    1.00    370.8±2.66µs        ? ?/sec
GUM/OptionalQueryAlternative            1.04     21.1±1.21ms        ? ?/sec    1.00     20.2±0.73ms        ? ?/sec
GUM/OptionalQueryNodeAtEnd              1.00     12.5±0.50ms        ? ?/sec    1.00     12.5±0.56ms        ? ?/sec
GUM/OptionalQueryNodeInBetween          1.04     13.1±0.46ms        ? ?/sec    1.00     12.6±0.41ms        ? ?/sec
GUM/Profile                             1.19     20.7±0.94ms        ? ?/sec    1.00     17.4±0.56ms        ? ?/sec
GUM/VV_dep                              1.00     18.9±1.10ms        ? ?/sec    1.01     19.1±1.28ms        ? ?/sec
GUM/city                                1.10   650.7±10.37µs        ? ?/sec    1.00    588.9±4.56µs        ? ?/sec
GUM/coffee                              1.04    409.5±5.82µs        ? ?/sec    1.00    394.0±7.70µs        ? ?/sec
GUM/corefAnno                           1.05  1704.1±20.32µs        ? ?/sec    1.00  1626.3±32.54µs        ? ?/sec
GUM/dep_xcomp                           1.00     40.3±0.69µs        ? ?/sec    1.00     40.2±0.38µs        ? ?/sec
GUM/edge_anno_regex                     1.00    312.4±2.78ms        ? ?/sec    1.01    314.8±3.93ms        ? ?/sec
GUM/entity                              1.04      4.3±0.07ms        ? ?/sec    1.00      4.1±0.08ms        ? ?/sec
GUM/kind_dom_kind                       1.09      6.5±0.08ms        ? ?/sec    1.00      5.9±0.03ms        ? ?/sec
GUM/meta_interview                      1.00      4.2±0.14ms        ? ?/sec    1.10      4.6±0.15ms        ? ?/sec
GUM/nonexisting_dep                     1.04    130.8±1.33µs        ? ?/sec    1.00    126.2±1.14µs        ? ?/sec
GUM/noun_with_metadata                  1.00      2.4±0.03ms        ? ?/sec    1.00      2.4±0.02ms        ? ?/sec
GUM/tok_dep_tok                         1.16     22.1±1.03ms        ? ?/sec    1.00     19.0±0.66ms        ? ?/sec
apply_update_complex_graph              1.03      3.4±0.20ms        ? ?/sec    1.00      3.4±0.22ms        ? ?/sec
apply_update_inmemory                   1.03       2.3±0.05s        ? ?/sec    1.00       2.3±0.02s        ? ?/sec
apply_update_ondisk                     1.01       5.7±0.09s        ? ?/sec    1.00       5.6±0.08s        ? ?/sec
count_extra_coref_anno                  1.00      2.9±0.18ms        ? ?/sec    1.07      3.1±0.24ms        ? ?/sec
count_extra_node                        1.00     26.1±0.21ms        ? ?/sec    1.01     26.4±0.31ms        ? ?/sec
deserialize_gum                         1.00    111.3±4.95ms        ? ?/sec    1.01    112.2±4.83ms        ? ?/sec
find_all_nouns_gum                      1.00     35.0±0.96ms        ? ?/sec    1.04     36.4±1.94ms        ? ?/sec
find_extra_all_nouns_gum                1.00     35.4±0.89ms        ? ?/sec    1.00     35.3±0.93ms        ? ?/sec
find_extra_first_ten_nouns_gum          1.06      9.2±0.60ms        ? ?/sec    1.00      8.6±0.37ms        ? ?/sec
find_extra_first_ten_token_gum          1.06     77.5±2.17µs        ? ?/sec    1.00     73.2±0.74µs        ? ?/sec
find_first_ten_nouns_gum                1.00      8.6±0.44ms        ? ?/sec    1.05      9.0±0.57ms        ? ?/sec
find_first_ten_token_gum                1.00     74.8±0.82µs        ? ?/sec    1.04     77.9±1.25µs        ? ?/sec
pcc2.1/AnyNodeIncludeSeed               1.08    315.0±3.98ms        ? ?/sec    1.00    290.7±2.73ms        ? ?/sec
pcc2.1/Benchmark1                       1.00     10.3±0.58ms        ? ?/sec    1.04     10.7±0.65ms        ? ?/sec
pcc2.1/Benchmark2                       1.00     85.3±1.73ms        ? ?/sec    1.04     89.1±2.81ms        ? ?/sec
pcc2.1/BrandenBurgSentence              1.02     11.3±0.34ms        ? ?/sec    1.00     11.0±0.33ms        ? ?/sec
pcc2.1/CatSearch                        1.00    637.9±2.23µs        ? ?/sec    1.01    642.3±9.73µs        ? ?/sec
pcc2.1/ConjunctionNearNounDirect        1.00  1270.2±20.93µs        ? ?/sec    1.06  1352.7±28.44µs        ? ?/sec
pcc2.1/ConjunctionNearNounDistance      1.00    956.1±9.46µs        ? ?/sec    1.03   987.1±14.56µs        ? ?/sec
pcc2.1/ConjunctionNearNounIndirect      1.00     46.6±1.53ms        ? ?/sec    1.00     46.8±1.32ms        ? ?/sec
pcc2.1/ConjunctionNearNounRange         1.00  1448.0±18.02µs        ? ?/sec    1.06  1530.7±56.54µs        ? ?/sec
pcc2.1/DepthFirst                       1.00     37.6±0.22µs        ? ?/sec    1.01     38.1±0.29µs        ? ?/sec
pcc2.1/DirectPointing                   1.01    210.9±5.39µs        ? ?/sec    1.00    209.2±1.47µs        ? ?/sec
pcc2.1/Inclusion                        1.02   854.5±19.47µs        ? ?/sec    1.00   836.4±17.70µs        ? ?/sec
pcc2.1/InclusionQuery                   1.06     11.3±0.75ms        ? ?/sec    1.00     10.7±0.75ms        ? ?/sec
pcc2.1/IndirectPointing                 1.07    289.4±6.52µs        ? ?/sec    1.00    271.4±1.44µs        ? ?/sec
pcc2.1/IsConnectedRange                 1.02     45.5±0.58µs        ? ?/sec    1.00     44.7±0.49µs        ? ?/sec
pcc2.1/KarolaAlignLemma                 1.00    290.6±5.48µs        ? ?/sec    1.01    292.9±8.63µs        ? ?/sec
pcc2.1/KarolaAlignTok                   1.06    341.2±3.16µs        ? ?/sec    1.00    321.7±3.01µs        ? ?/sec
pcc2.1/KarolaOr                         1.00     61.2±1.06µs        ? ?/sec    1.00     61.2±1.34µs        ? ?/sec
pcc2.1/LemmaTokEqual                    1.05   708.0±28.84µs        ? ?/sec    1.00    673.5±6.04µs        ? ?/sec
pcc2.1/LemmaTokNotEqual                 1.04    720.1±4.80µs        ? ?/sec    1.00   693.7±32.53µs        ? ?/sec
pcc2.1/MMaxAnnos_ambiguity              1.02    259.7±3.19µs        ? ?/sec    1.00    254.7±2.62µs        ? ?/sec
pcc2.1/MMaxAnnos_complex_np             1.04     82.8±2.55µs        ? ?/sec    1.00     79.8±1.22µs        ? ?/sec
pcc2.1/MultiDominance                   1.01     63.8±2.50ms        ? ?/sec    1.00     63.4±3.39ms        ? ?/sec
pcc2.1/NNNearARTDIndirect               1.00    144.0±3.31ms        ? ?/sec    1.05    151.0±3.54ms        ? ?/sec
pcc2.1/NNNearARTDirect                  1.00      3.8±0.18ms        ? ?/sec    1.00      3.8±0.15ms        ? ?/sec
pcc2.1/NPThreeOut                       1.02    148.9±5.71ms        ? ?/sec    1.00    146.4±4.82ms        ? ?/sec
pcc2.1/NewInDirect                      1.00   384.6±12.34µs        ? ?/sec    1.03    394.9±5.39µs        ? ?/sec
pcc2.1/NodeCount                        1.01      3.4±0.07ms        ? ?/sec    1.00      3.3±0.01ms        ? ?/sec
pcc2.1/NodeIdentCovNode                 1.00     84.8±0.90ms        ? ?/sec    1.01     85.3±1.72ms        ? ?/sec
pcc2.1/NonExistingDominanceLeft         1.04    449.7±4.20µs        ? ?/sec    1.00    432.6±3.48µs        ? ?/sec
pcc2.1/NotDocument                      1.00     16.4±0.69ms        ? ?/sec    1.01     16.5±0.73ms        ? ?/sec
pcc2.1/NotNoun                          1.03      5.2±0.41ms        ? ?/sec    1.00      5.0±0.41ms        ? ?/sec
pcc2.1/NotProperNound                   1.07      5.4±0.46ms        ? ?/sec    1.00      5.0±0.16ms        ? ?/sec
pcc2.1/NotWennExact                     1.00     44.3±0.53µs        ? ?/sec    1.01     44.7±0.86µs        ? ?/sec
pcc2.1/NotWennRegex                     1.00     94.0±0.72µs        ? ?/sec    1.01     95.2±0.86µs        ? ?/sec
pcc2.1/Overlap                          1.02  1621.4±52.32µs        ? ?/sec    1.00  1595.6±45.47µs        ? ?/sec
pcc2.1/PPNotModifier                    1.04      5.3±0.42ms        ? ?/sec    1.00      5.1±0.37ms        ? ?/sec
pcc2.1/PluralNP                         1.00      3.9±0.20ms        ? ?/sec    1.00      3.8±0.19ms        ? ?/sec
pcc2.1/PosEqual                         1.00     32.0±1.91ms        ? ?/sec    1.03     33.0±2.90ms        ? ?/sec
pcc2.1/PosNotEqual                      1.00     14.5±0.89ms        ? ?/sec    1.01     14.6±1.09ms        ? ?/sec
pcc2.1/PosValueSearch                   1.01    295.5±1.51µs        ? ?/sec    1.00    294.0±5.24µs        ? ?/sec
pcc2.1/Precedence                       1.00     46.4±1.63ms        ? ?/sec    1.09     50.6±0.67ms        ? ?/sec
pcc2.1/PrecedenceMixedSpanTok           1.01     39.7±0.87µs        ? ?/sec    1.00     39.1±1.35µs        ? ?/sec
pcc2.1/RangedDominance                  1.00      6.6±0.39ms        ? ?/sec    1.01      6.7±0.31ms        ? ?/sec
pcc2.1/Regex                            1.02     18.4±1.43ms        ? ?/sec    1.00     17.9±0.74ms        ? ?/sec
pcc2.1/SegmentCount                     1.00    125.3±0.92µs        ? ?/sec    1.00    124.7±2.25µs        ? ?/sec
pcc2.1/SegmentNearDirect                1.00    260.8±1.22µs        ? ?/sec    1.04    270.8±3.11µs        ? ?/sec
pcc2.1/SegmentNearIndirect              1.00     11.1±0.41ms        ? ?/sec    1.01     11.2±0.26ms        ? ?/sec
pcc2.1/SegmentNearRange                 1.00  1020.6±28.79µs        ? ?/sec    1.04  1063.1±10.42µs        ? ?/sec
pcc2.1/StructureInclusionSeed           1.06     22.5±1.39ms        ? ?/sec    1.00     21.3±0.91ms        ? ?/sec
pcc2.1/TestQueryOverlap1                1.00     10.1±0.40ms        ? ?/sec    1.02     10.3±0.48ms        ? ?/sec
pcc2.1/TestQueryOverlap2                1.03     10.1±0.68ms        ? ?/sec    1.00      9.9±0.57ms        ? ?/sec
pcc2.1/TokIdentCovNN                    1.03      8.4±0.72ms        ? ?/sec    1.00      8.1±0.68ms        ? ?/sec
pcc2.1/TokIdentCovNode                  1.05      8.4±0.92ms        ? ?/sec    1.00      8.0±0.50ms        ? ?/sec
pcc2.1/TokenIndex                       1.03     37.1±0.31µs        ? ?/sec    1.00     36.1±0.26µs        ? ?/sec
pcc2.1/TokenPrecedence                  1.00     10.3±0.54ms        ? ?/sec    1.01     10.4±0.33ms        ? ?/sec
pcc2.1/TokenPrecedenceThreeNodes        1.01      9.4±0.44ms        ? ?/sec    1.00      9.4±0.31ms        ? ?/sec
subtok.demo/NearSegmentationDirect      1.03     31.9±0.71µs        ? ?/sec    1.00     31.1±0.26µs        ? ?/sec
subtok.demo/NearSegmentationIndirect    1.02     33.6±0.35µs        ? ?/sec    1.00     32.9±0.46µs        ? ?/sec
subtok.demo/NonExistingWithoutValue     1.02     38.3±0.29µs        ? ?/sec    1.00     37.6±0.16µs        ? ?/sec
subtok.demo/ThisTokenized               1.00     32.9±0.36µs        ? ?/sec    1.02     33.5±0.74µs        ? ?/sec

MartinKl added 4 commits October 9, 2026 11:08

for performance reasons, it is always best to duplicate named dominan…

2fca938

…ce edges in the unnamed default dominance component. To keep this load off the corpus building side, it is integrated into apply_update_graph_index of AnnotationComponent

update

6cf783f

remove unused import

de484e0

updated snapshot

f859801

MartinKl requested a review from thomaskrause October 9, 2026 09:17

thomaskrause added 3 commits October 12, 2026 10:50

Add a benchmark for applying updates to a graph with dominance edges

24e67c9

Directly write the edge to the component instead of collecting it first

2b643ec

Only add a new edge to the default dominance component if edge is not…

3f6ffb3

… in any other unnamed component

Add explicit test that the edges are added

6dd84c3

thomaskrause marked this pull request as draft October 12, 2026 16:45

thomaskrause added 2 commits October 12, 2026 19:15

Move to member function

c6e50e7

Merge branch 'apply-update-with-dominance-benchmark' into feature/dou…

a47fdd6

…ble-named-dominance-edges-in-index-update

thomaskrause approved these changes Oct 12, 2026

View reviewed changes

thomaskrause marked this pull request as ready for review October 12, 2026 17:26

thomaskrause marked this pull request as draft October 13, 2026 08:08

thomaskrause self-assigned this Oct 13, 2026

Only include non-empty graph storages for arity and base edge operato…

f467758

…r (e.g. Dominance)

thomaskrause marked this pull request as ready for review October 14, 2026 13:46

thomaskrause merged commit fd70c5b into main Oct 14, 2026
10 checks passed

Navigation Menu

Repository navigation

Feature/double named dominance edges in index update - #347

Feature/double named dominance edges in index update#347
thomaskrause merged 11 commits into
mainfrom
feature/double-named-dominance-edges-in-index-update

MartinKl commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 •

edited

Loading

Uh oh!

thomaskrause left a comment

Uh oh!

thomaskrause commented Oct 13, 2026

Uh oh!

thomaskrause commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

MartinKl commented Oct 9, 2026

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomaskrause left a comment

Choose a reason for hiding this comment

Uh oh!

thomaskrause commented Oct 13, 2026

Uh oh!

thomaskrause commented Oct 14, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Oct 12, 2026 •

edited

Loading